[12.x] Ensure HttpClientTest doesnt flake in Windows CI#58817
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Feb 14, 2026
Merged
[12.x] Ensure HttpClientTest doesnt flake in Windows CI#58817taylorotwell merged 1 commit intolaravel:12.xfrom
taylorotwell merged 1 commit intolaravel:12.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
45b8b23 to
c870579
Compare
Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Revert "Update HttpClientTest.php" This reverts commit 56f5050. Reapply "Update HttpClientTest.php" This reverts commit 56ccc35. dont need this either? Revert "dont need this either?" This reverts commit f924c16.
jackbayliss
added a commit
to jackbayliss/framework
that referenced
this pull request
Feb 19, 2026
Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Revert "Update HttpClientTest.php" This reverts commit 56f5050. Reapply "Update HttpClientTest.php" This reverts commit 56ccc35. dont need this either? Revert "dont need this either?" This reverts commit f924c16.
DarkGhostHunter
pushed a commit
to DarkGhostHunter/laravel-framework
that referenced
this pull request
Feb 22, 2026
Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Update HttpClientTest.php Revert "Update HttpClientTest.php" This reverts commit 56f5050. Reapply "Update HttpClientTest.php" This reverts commit 56ccc35. dont need this either? Revert "dont need this either?" This reverts commit f924c16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is failing on Windows CI for main (https://github.com/laravel/framework/actions/runs/22018381865/job/63623484837) and a bunch of PRs (such as https://github.com/laravel/framework/actions/runs/22020748052/job/63629394985) cause its the only test that makes a real http request and awaits the result from what I can see.
Rather than use https:// i've changed it to just use http:// as it doesn't matter - which means we have no failure.