[12.x] do assignment instead of mutating to handle immutable carbon object.#58498
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Jan 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I checked this laravel/cashier-stripe#1810 and some PRs related to it, and, like you, it was also working for me. But I was curious, so I did some deep digging into it, and I found that
publishedAtproperty gets initialised withnow(), which usesDate::now()behind the scenes and when someone usesDate::use(CarbonImmutable::class)at that moment it does not mutate. It creates a new object for each iteration. It creates all migrations with the same date and time that makes it resort in alphabetical order and that's why adding column migration runs before creating table migration.