[12.x] Add hasSole() method to collections#58463
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Jan 23, 2026
Merged
Conversation
8ec5fbc to
ea0ab6f
Compare
ea0ab6f to
edfe526
Compare
Contributor
We were so close to getting |
|
And a handy mnemonic to remember this one |
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
containsOneItem()tohasSole(), and adds callback and operator support.Background
Back in #36428, I added an
isSingle()method to check if a collection contains exactly one item. Taylor later renamed it tocontainsOneItem()because—and I quote—"it's not a dating app" 😄The problem is that
containsOneItem()is actually longer thancount() === 1, making the method rather pointless.New Method
Now that we have the
sole()nomenclature, we can add ahasSole()method that...containsOneItem()sole()(callback, key/value, and full operator syntax)Deprecation
containsOneItem()is now deprecated and delegates tohasSole().Laravel 13
After this is merged, and then merged into
master, we'll add this method to theEnumerableinterface, and remove thecontainsOneItem()method completely.