fix nil pointer exception when calling Start again after address binding error#2131
Merged
aldas merged 1 commit intolabstack:masterfrom Mar 15, 2022
Merged
fix nil pointer exception when calling Start again after address binding error#2131aldas merged 1 commit intolabstack:masterfrom
aldas merged 1 commit intolabstack:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2131 +/- ##
=======================================
Coverage 92.10% 92.11%
=======================================
Files 37 37
Lines 3028 3030 +2
=======================================
+ Hits 2789 2791 +2
Misses 150 150
Partials 89 89
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a nil pointer exception because the code assigns a nil value to an interface (
e.Listener) which ends up creating a non-nil interface containing a nil pointer. Using this will result in the nil pointer exception and checking thee.Listeneragainstnilwill befalse-- which is why the Listener is not recreated and overwritten the during the second call toStart.Small code example that triggers this error (given an existing echo router):