Skip to content

✨ Adds new option timeoutSeconds to inform the the timeout for webhook resources#784

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
yaa110:timeout-seconds
May 15, 2023
Merged

✨ Adds new option timeoutSeconds to inform the the timeout for webhook resources#784
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
yaa110:timeout-seconds

Conversation

@yaa110
Copy link
Contributor

@yaa110 yaa110 commented Mar 12, 2023

I needed to change timeoutSeconds default value in a project created using kubebuilder and I realized that it is not possible to do that. So, I opened this PR.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 12, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yaa110 / name: Navid (d4b2c51)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 12, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 12, 2023

Welcome @yaa110!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 12, 2023

Hi @yaa110. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy March 12, 2023 02:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2023
camilamacedo86
camilamacedo86 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting. I am OK with this one.
However, can we better address what changes here in the tiltle?
I added a suggestion on it. See that 🌱 is used only for changes that does not affect the end-users.

Otherwise,

/lgtm

@alvaroaleman @vincepri wdyt?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@camilamacedo86 camilamacedo86 changed the title 🌱 Parser: implement timeoutSeconds config ✨ : Add new option timeoutSeconds to inform the the timeout for webhook resources Apr 19, 2023
@camilamacedo86
Copy link
Member

camilamacedo86 commented Apr 19, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
camilamacedo86
camilamacedo86 reviewed Apr 19, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@camilamacedo86 camilamacedo86 changed the title ✨ : Add new option timeoutSeconds to inform the the timeout for webhook resources ✨ Adda new option timeoutSeconds to inform the the timeout for webhook resources Apr 19, 2023
@camilamacedo86 camilamacedo86 changed the title ✨ Adda new option timeoutSeconds to inform the the timeout for webhook resources ✨ Adds new option timeoutSeconds to inform the the timeout for webhook resources Apr 19, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@yaa110
Copy link
Contributor Author

yaa110 commented Apr 21, 2023

@camilamacedo86 thank you for reviewing the PR. The commit message has been amended based on your edit.

camilamacedo86
camilamacedo86 approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

I am ok with this one 👍
Let's see what others think about

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 12, 2023
@sbueringer
Copy link
Member

sbueringer commented May 15, 2023

Thank you!

/lgtm

@sbueringer
Copy link
Member

sbueringer commented May 15, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, sbueringer, yaa110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 784dec2 into kubernetes-sigs:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

1 more reviewer

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sbueringer sbueringer

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yaa110 @k8s-ci-robot @camilamacedo86 @sbueringer