🌱chore: Update golangci-lint version to v2.10.1#3470
Conversation
Signed-off-by: dongjiang <dongjiang2010@gmail.com>
|
Looks like the nolint's are somehow not working, maybe they have to be in different files somehow? (https://github.com/kubernetes-sigs/controller-runtime/actions/runs/22764085086?pr=3470) |
| # Allow 'version' as a package name even though it conflicts with Go 1.24+ stdlib | ||
| - linters: | ||
| - revive | ||
| path: tools/setup-envtest/version/.*\.go$ |
There was a problem hiding this comment.
Maybe let's just use the nolint comments consistently for this one instead of also adding an exclude here?
There was a problem hiding this comment.
Thanks @sbueringer
Fixed
So many nolint add, just add in .golangci.yml
Signed-off-by: dongjiang <dongjiang2010@gmail.com>
Signed-off-by: dongjiang <dongjiang2010@gmail.com>
|
Thx! /lgtm |
|
LGTM label has been added. DetailsGit tree hash: ba7482cb487b43fbfa583c0aaf7007e65bf6e42c |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dongjiang1989, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.