Skip to content

⚠ webhook: remove deprecated custom path function#3465

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
damsien:main
Mar 3, 2026
Merged

⚠ webhook: remove deprecated custom path function#3465
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
damsien:main

Conversation

@damsien

@damsien damsien commented Mar 3, 2026

Copy link
Copy Markdown
Member

Remove the WithCustomPath() deprecated function. It has been replaced by WithValidatorCustomPath() and WithDefaulterCustomPath() about a year ago.

@damsien
chore(webhook): remove custom path deprecated function
2110776 
Signed-off-by: Damien DASSIEU <ddassieu@scaleway.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2026
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 3, 2026
@k8s-ci-robot k8s-ci-robot requested a review from troy0820 March 3, 2026 10:11
@k8s-ci-robot

k8s-ci-robot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Hi @damsien. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2026
@sbueringer

sbueringer commented Mar 3, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2026
@sbueringer

sbueringer commented Mar 3, 2026

Copy link
Copy Markdown
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damsien, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

k8s-ci-robot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: bd347af7d23134a6cb4716079d9b70dff8029911

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@sbueringer sbueringer changed the title 🌱 chore(webhook): remove custom path deprecated function ⚠ webhook: remove deprecatedcustom path function Mar 3, 2026
@sbueringer sbueringer changed the title ⚠ webhook: remove deprecatedcustom path function ⚠ webhook: remove deprecated custom path function Mar 3, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

@damsien: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff 2110776 link false /test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 955f7df into kubernetes-sigs:main Mar 3, 2026
20 of 21 checks passed
@damsien damsien mentioned this pull request Mar 30, 2026
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@troy0820 troy0820 Awaiting requested review from troy0820

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damsien @k8s-ci-robot @sbueringer