🌱 Deflake certwatcher tests#3457
Merged
Merged
Conversation
sbueringer
reviewed
Feb 16, 2026
|
|
||
| ctxCancel() | ||
| Eventually(doneCh, "4s").Should(BeClosed()) | ||
| Expect(testutil.ToFloat64(metrics.ReadCertificateTotal)).To(BeNumerically(">=", readCertificateTotalBefore+1)) |
Member
There was a problem hiding this comment.
Should this still be >= or equals now?
(same below)
Member
Author
There was a problem hiding this comment.
Yes of course, done
In the certwatcher tests, we use `start_watcher` which starts the certwatcher in a goroutine. Once it is started, it sets up an fsnotify and reacts to events. The metric test rely both on the gorouine starting fast enough and the fsnotify events being processed fast enough through eventually. In CI, the four second timeout that was used isn't always sufficient, resulting in flakes. Given that there are dedicated tests for inotify event handling, this change changes the metric tests to explicitly call `ReadCertificate` and then validating the metrics.
6d3e710 to
04d8320
Compare
Member
|
Thx! /lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 7ed712827edef3da760b47cfdcd83a34761e8d43 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the certwatcher tests, we use
start_watcherwhich starts the certwatcher in a goroutine. Once it is started, it sets up an fsnotify and reacts to events.The metric test rely both on the gorouine starting fast enough and the fsnotify events being processed fast enough through eventually. In CI, the four second timeout that was used isn't always sufficient, resulting in flakes.
Given that there are dedicated tests for inotify event handling, this change changes the metric tests to explicitly call
ReadCertificateand then validating the metrics.