🌱 Use forked version of btree#3449
Conversation
|
This has to wait until we bump the k8s.io/* deps to a version that has the k8s.io/utils change |
Couldn’t the k8s.io/utils dependency be bumped separately? The changes there are done carefully enough that there shouldn’t be any risk for controller-runtime or its dependants. |
|
@skitt we try to keep the versions of the k8s.io/ deps in sync with what is in k/k. We can setup exceptions for that if we have a good reason, but in this case I think it's fine to just wait for the next release |
|
lgtm/approve pending rebase (alpha.1 bump PR is now merged) |
Following the upstream change in kubernetes/kubernetes#136415
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 similar comments
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 472752209e0cb4f9ed3f722e24912fd654ed8571 |
1 similar comment
|
LGTM label has been added. DetailsGit tree hash: 472752209e0cb4f9ed3f722e24912fd654ed8571 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following the upstream change in kubernetes/kubernetes#136415