remove special isolated region check for listener attributes#4690
Merged
zac-nixon merged 2 commits intokubernetes-sigs:mainfrom Apr 16, 2026
Merged
remove special isolated region check for listener attributes#4690zac-nixon merged 2 commits intokubernetes-sigs:mainfrom
zac-nixon merged 2 commits intokubernetes-sigs:mainfrom
Conversation
shraddhabang
approved these changes
Apr 16, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0953e38 to
cc56fd1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4690 +/- ##
==========================================
+ Coverage 50.39% 56.21% +5.82%
==========================================
Files 205 378 +173
Lines 12109 29878 +17769
==========================================
+ Hits 6102 16797 +10695
- Misses 5590 12155 +6565
- Partials 417 926 +509 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have closed the parity gaps in special AWS partitions, therefore we don't need the check anymore. Also, I refactored the protocol blocking for listener attributes to correctly match what the AWS API allows.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯