Skip to content

ignore listenerset when CRD is missing#4689

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
zac-nixon:main
Apr 17, 2026
Merged

ignore listenerset when CRD is missing#4689
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
zac-nixon:main

Conversation

@zac-nixon
Copy link
Copy Markdown
Collaborator

@zac-nixon zac-nixon commented Apr 15, 2026 •
edited
Loading

Issue

#4684

Description

When ListenerSet CRD is not present, we currently crash. This PR makes it so we simply ignore listener set operations.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2026
@zac-nixon zac-nixon closed this Apr 16, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2026
@zac-nixon zac-nixon reopened this Apr 16, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 8.33333% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.24%. Comparing base (ed8bd00) to head (1c39f78).
⚠️ Report is 801 commits behind head on main.

Files with missing lines Patch % Lines
controllers/gateway/gateway_controller.go 0.00% 23 Missing and 2 partials ⚠️
pkg/gateway/routeutils/loader.go 0.00% 8 Missing ⚠️
pkg/gateway/routeutils/listener_set.go 0.00% 5 Missing ⚠️
pkg/gateway/crddetect/gateway_feature_flags.go 50.00% 4 Missing ⚠️
...ntrollers/gateway/listenerset_status_reconciler.go 0.00% 1 Missing ⚠️
pkg/config/feature_gates.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4689      +/-   ##
==========================================
+ Coverage   50.39%   56.24%   +5.84%     
==========================================
  Files         205      378     +173     
  Lines       12109    29910   +17801     
==========================================
+ Hits         6102    16822   +10720     
- Misses       5590    12159    +6569     
- Partials      417      929     +512

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wweiwei-li, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [wweiwei-li,zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shuqz
Copy link
Copy Markdown
Collaborator

shuqz commented Apr 17, 2026

/approved
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2026
@k8s-ci-robot k8s-ci-robot merged commit 29e7577 into kubernetes-sigs:main Apr 17, 2026
9 checks passed
@zac-nixon zac-nixon mentioned this pull request Apr 18, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wweiwei-li wweiwei-li wweiwei-li approved these changes

@oliviassss oliviassss Awaiting requested review from oliviassss

@shuqz shuqz Awaiting requested review from shuqz

Assignees

@shuqz shuqz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zac-nixon @codecov-commenter @k8s-ci-robot @shuqz @wweiwei-li