Skip to content

Fix FindLoadBalancerByDNSName to be case-insensitive#4657

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
bobert-2:fix-tests
Mar 31, 2026
Merged

Fix FindLoadBalancerByDNSName to be case-insensitive#4657
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
bobert-2:fix-tests

Conversation

@bobert-2
Copy link
Copy Markdown
Contributor

@bobert-2 bobert-2 commented Mar 31, 2026

Description

Currently, FindLoadBalancerByDNSName fails if the load balancer name has capital letters since the ingress dnsName will always be lowercase. DNS names are case-insensitive so we should update this function to perform a case-insensitive check.

This PR replaces == check with strings.EqualFold.

// EqualFold reports whether s and t, interpreted as UTF-8 strings,
// are equal under simple Unicode case-folding, which is a more general
// form of case-insensitivity.
https://pkg.go.dev/strings#EqualFold

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot requested review from shuqz and zac-nixon March 31, 2026 20:02
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 31, 2026

Hi @kellyyan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 31, 2026
@shuqz
Copy link
Copy Markdown
Collaborator

shuqz commented Mar 31, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2026
@shuqz
Copy link
Copy Markdown
Collaborator

shuqz commented Mar 31, 2026

/approved

@wweiwei-li
Copy link
Copy Markdown
Collaborator

wweiwei-li commented Mar 31, 2026

/approved
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kellyyan, shuqz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@k8s-ci-robot k8s-ci-robot merged commit 0a207d8 into kubernetes-sigs:main Mar 31, 2026
9 checks passed
@zac-nixon zac-nixon mentioned this pull request Apr 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuqz shuqz shuqz approved these changes

@zac-nixon zac-nixon Awaiting requested review from zac-nixon

Assignees

@wweiwei-li wweiwei-li

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobert-2 @k8s-ci-robot @shuqz @wweiwei-li