Skip to content

fix: Allowing namespace selectors for mservice webhook#4646

Merged
k8s-ci-robot merged 4 commits intokubernetes-sigs:mainfrom
wesbrownfavor:mservice-namespace-selector
Mar 26, 2026
Merged

fix: Allowing namespace selectors for mservice webhook#4646
k8s-ci-robot merged 4 commits intokubernetes-sigs:mainfrom
wesbrownfavor:mservice-namespace-selector

Conversation

@wesbrownfavor
Copy link
Copy Markdown
Contributor

@wesbrownfavor wesbrownfavor commented Mar 26, 2026

Issue

#4627

Description

Adding the value serviceMutatorWebhookConfig.namespaceSelectors to allow setting namespaces selectors for the mservice webhook.

It can be used as follows:

serviceMutatorWebhookConfig:
  namespaceSelectors:
    - key: "kubernetes.io/metadata.name"
      operator: "NotIn"
      values:
        - "kube-system"

I chose to put this under serviceMutatorWebhookConfig instead of out in the open like webhookNamespaceSelectors as I feel you would want to set this to a service mutator specific config. Let me know if that goes against any design considerations.

Checklist

  • [n/a] Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 26, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 26, 2026

Hi @wesbrownfavor. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2026
@wesbrownfavor
Copy link
Copy Markdown
Contributor Author

wesbrownfavor commented Mar 26, 2026 •
edited
Loading

I've got a ticket in with the Linux Foundation. As far as we can tell on our end everything is setup 🤷

@zac-nixon
Copy link
Copy Markdown
Collaborator

zac-nixon commented Mar 26, 2026 •
edited
Loading

It takes some time for the CLA to propagate, I'll check back in a couple hours to see if it's been approved. If not, I'll figure out what's going on.

Thanks for taking the time to contribute.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 26, 2026
@wesbrownfavor
Copy link
Copy Markdown
Contributor Author

wesbrownfavor commented Mar 26, 2026

All set on the CLA. I had to click an extra button. Let me know if you all need anything else from me on this PR.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
shraddhabang
shraddhabang approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shraddhabang shraddhabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shraddhabang, wesbrownfavor, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [shraddhabang,zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 77a80ad into kubernetes-sigs:main Mar 26, 2026
9 checks passed
@wesbrownfavor wesbrownfavor deleted the mservice-namespace-selector branch March 27, 2026 14:27
@zac-nixon zac-nixon mentioned this pull request Apr 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zac-nixon zac-nixon zac-nixon approved these changes

@shraddhabang shraddhabang shraddhabang approved these changes

@wweiwei-li wweiwei-li Awaiting requested review from wweiwei-li

Assignees

@shraddhabang shraddhabang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wesbrownfavor @k8s-ci-robot @zac-nixon @shraddhabang