[Gateway API] Validate ListenerSet listeners#4629
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Mar 19, 2026
Merged
[Gateway API] Validate ListenerSet listeners#4629k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
0b0b899 to
0cba293
Compare
shuqz
reviewed
Mar 19, 2026
| irrelevantResourceHandshakeState handshakeState = "irrelevant" | ||
| ) | ||
|
|
||
| type mockListenerSetLoader struct { |
Collaborator
There was a problem hiding this comment.
do we wanna put mock to a test file?
shuqz
reviewed
Mar 19, 2026
wweiwei-li
reviewed
Mar 19, 2026
| } | ||
| }() | ||
|
|
||
| lsListeners, rejectedListenerSets, err := l.lsLoader.retrieveListenersFromListenerSets(ctx, gw) |
Collaborator
There was a problem hiding this comment.
How do you think spelling out "listenerSet" everywhere instead of ls. I feel ls a little ambiguous, It is easy to understand it as shorthand for listener.
wweiwei-li
reviewed
Mar 19, 2026
wweiwei-li
reviewed
Mar 19, 2026
wweiwei-li
approved these changes
Mar 19, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate Listeners originating from the ListenerSets are valid. This follows the precendence ordering found here. What this PR does NOT do, 1/ adds the listener entries from a listenerset into the gateway, 2/ handles listener status updates.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯