Skip to content

Add missing feature gates to docs and fix search bar#4618

Merged
zac-nixon merged 2 commits intokubernetes-sigs:mainfrom
swibrow:main
Mar 13, 2026
Merged

Add missing feature gates to docs and fix search bar#4618
zac-nixon merged 2 commits intokubernetes-sigs:mainfrom
swibrow:main

Conversation

@swibrow
Copy link
Copy Markdown
Contributor

@swibrow swibrow commented Mar 11, 2026 •
edited
Loading

Issue

Undocumented featuregates

Description

Added missing feature gates to the documentation and helm chart values:

docs/deploy/configurations.md - Added 4 missing feature gates:

  • SubnetDiscoveryByReachability
  • NLBGatewayAPI
  • ALBGatewayAPI
  • ALBTargetControlAgent

helm/values.yaml - Added 5 missing commented examples:

  • EnableTCPUDPListener
  • EnableRGTAPI
  • NLBSecurityGroup
  • SubnetDiscoveryByReachability
  • NLBGatewayAPI
  • ALBGatewayAPI

docs/theme_overrides/partials/header.html - Fixed search bar not appearing by updating the plugin check from "search" to
"material/search" to match mkdocs-material 9.5.31.

Note: The default values for ALBGatewayAPI and NLBGatewayAPI are true in the source code, but I needed to explicitly set
ALBGatewayAPI: true in the helm values to get it working. The documented defaults may not reflect actual behavior — needs confirmation from maintainers.

This could have been fixed in the commit two days ago

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

swibrow added 2 commits March 11, 2026 16:09
@swibrow
Add missing feature gates to docs and helm values
00571ba 
Add SubnetDiscoveryByReachability, NLBGatewayAPI, ALBGatewayAPI, and
ALBTargetControlAgent to the feature gates documentation. Add
EnableTCPUDPListener, EnableRGTAPI, NLBSecurityGroup,
SubnetDiscoveryByReachability, NLBGatewayAPI, and ALBGatewayAPI to
the helm chart values.yaml commented examples.
@swibrow
Fix search bar not appearing in docs
caddf96 
Update the custom header template to check for "material/search"
instead of "search" in config plugins, matching the upstream
mkdocs-material 9.5.31 template. Also enable search.suggest and
search.highlight features.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 11, 2026

Welcome @swibrow!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 11, 2026

Hi @swibrow. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swibrow
Once this PR has been reviewed and has the lgtm label, please assign shuqz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zac-nixon
Copy link
Copy Markdown
Collaborator

zac-nixon commented Mar 11, 2026

/ok-to-test
Thank you for the PR! :)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2026
@zac-nixon zac-nixon merged commit 4bf94e9 into kubernetes-sigs:main Mar 13, 2026
8 of 9 checks passed
@zac-nixon zac-nixon mentioned this pull request Apr 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuqz shuqz Awaiting requested review from shuqz

@wweiwei-li wweiwei-li Awaiting requested review from wweiwei-li

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swibrow @k8s-ci-robot @zac-nixon