Upgrade to v1.5 of Gateway API#4613
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| There a few backwards incompatible release. | ||
|
|
||
| - Going from a version less than v1.5 | ||
| - v1.5 brings TLSRoute out of alpha and into the v1 API version. Once this happens, old versions of the controller will not work with TLSRoutes. |
There was a problem hiding this comment.
v1.5 brings TLSRoute out of alpha and into the v1 API version. Once this happens, old versions of the controller will not work with TLSRoutes.
Is the statement true? The older version of the controller will not work with v1 TLSRoutes, but they'll still work with v1alpha2 TLSRoutes , right ?. We would better say users must ensure their TLSRoute match the API version their controller expects.
There was a problem hiding this comment.
Unfortunately the statement is true. The Gateway API community decide to set storage = false, serve = false for TLSRoutes on alpha2, meaning that the API won't return them. I am thinking for our v3.2.0 release, we will update the CRDs to set storage = true, to allow seamless transition for users.
|
outside scope of this PR, if we are updating gateway api version, we need to run conformance test again |
|
/lgtm |
Description
Upgrade to use v1.5 of Gateway API. Main change is that TLSRoute moves alpha2 to v1. Need to work through the guidance for customers still, as the current Gateway CRDs remove TLSRoute entirely from alpha2 (effectively breaking users)
Also, threw in a small refactor to support listenersets (next pr, it will be ~largeish)
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯