Skip to content

feat: graduate MatchLabelKeysInPodAffinity to GA#130463

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sanposhiho:ga-mlk
Mar 19, 2025
Merged

feat: graduate MatchLabelKeysInPodAffinity to GA#130463
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sanposhiho:ga-mlk

Conversation

@sanposhiho
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho commented Feb 27, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

kubernetes/enhancements#3633

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduate the MatchLabelKeys (MismatchLabelKeys) feature in PodAffinity (PodAntiAffinity) to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 27, 2025
@sanposhiho sanposhiho mentioned this pull request Feb 27, 2025
Closed
12 tasks
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Feb 27, 2025

/cc @alculquicondor @Huang-Wei

@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Feb 27, 2025

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 27, 2025
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Feb 27, 2025

/assign @ahg-g

looks like @ahg-g is the only owner of this file from sig-scheduling.

@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Feb 27, 2025

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2025
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Feb 27, 2025

/cc @macsko @dom4ha

@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 27, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 17, 2025

LGTM label has been added.

DetailsGit tree hash: 16a816c27442aa17d055dec51379ac9286291a03

@ahg-g
Copy link
Copy Markdown
Member

ahg-g commented Mar 18, 2025

/approve

@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Mar 19, 2025 •
edited
Loading

@kubernetes/api-approvers Can anyone take a look at this? For the API-review area, it's just a minor change in the comments on the API.

liggitt
liggitt reviewed Mar 19, 2025
View reviewed changes
Comment thread test/integration/scheduler/scoring/priorities_test.go Outdated
liggitt
liggitt reviewed Mar 19, 2025
View reviewed changes
Comment thread test/integration/scheduler/filters/filters_test.go
liggitt
liggitt reviewed Mar 19, 2025
View reviewed changes
Comment thread test/integration/scheduler/filters/filters_test.go Outdated
liggitt
liggitt reviewed Mar 19, 2025
View reviewed changes
Comment thread pkg/registry/core/pod/strategy_test.go Outdated
liggitt
liggitt reviewed Mar 19, 2025
View reviewed changes
Comment thread pkg/api/pod/util_test.go Outdated
@liggitt liggitt moved this to API review completed, 1.33 in API Reviews Mar 19, 2025
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Mar 19, 2025

API comment change lgtm, one comment on limiting emulation version in the tests to when we need to disable the gate

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 19, 2025
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Mar 19, 2025

@liggitt Thanks, updated based on your suggestion: https://github.com/kubernetes/kubernetes/compare/537f04603fd1734b231beb9152137f7a00661373..10c6a4258f83dc0e05f8fe835d7c78f07fd311d6

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Mar 19, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 19, 2025

LGTM label has been added.

DetailsGit tree hash: dbb0380369a011bd9c633f7ebfa1dfdab613b18a

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, Huang-Wei, liggitt, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Mar 19, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit f1c634f into kubernetes:master Mar 19, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 19, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Mar 19, 2025
@aslatter
Copy link
Copy Markdown

aslatter commented Jun 2, 2025

Should I read anything into matchLabelKeys being GA in pod-affinity, but still beta in topology-spread-constraints? Is the idea that doing the things I want to do with matchLabelKeys is more likely to work in pod-affinity than in topology-spread-constraints? Or are the two features simply moving on a different track?

@aslatter
Copy link
Copy Markdown

aslatter commented Jun 2, 2025

Should I read anything into matchLabelKeys being GA in pod-affinity, but still beta in topology-spread-constraints? Is the idea that doing the things I want to do with matchLabelKeys is more likely to work in pod-affinity than in topology-spread-constraints? Or are the two features simply moving on a different track?

It looks like I need to track this issue: kubernetes/enhancements#3243

For other outsiders trying to follow along, the issue with matchLabelKeys for topology-spread-constraints was this issue: #129480

@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Jun 3, 2025

They are different features tracked separately. But, we are working on the spreading one as well, and pushing forward in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@macsko macsko Awaiting requested review from macsko

@ahg-g ahg-g Awaiting requested review from ahg-g

@deads2k deads2k Awaiting requested review from deads2k

@dom4ha dom4ha Awaiting requested review from dom4ha

+2 more reviewers

@Jefftree Jefftree Jefftree left review comments

@siyuanfoundation siyuanfoundation siyuanfoundation left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@liggitt liggitt

@deads2k deads2k

@ahg-g ahg-g

@macsko macsko

@dom4ha dom4ha

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

API Reviews
Status: API review completed, 1.33
SIG Apps
Archived in project
SIG Node CI/Test Board
Archived in project

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.