Skip to content

Automated cherry pick of #135017: Fix spurious statefulset rollout from 1.33 → 1.34#135087

Merged
k8s-ci-robot merged 3 commits intokubernetes:release-1.34from
liggitt:automated-cherry-pick-of-#135017-upstream-release-1.34
Nov 8, 2025
Merged

Automated cherry pick of #135017: Fix spurious statefulset rollout from 1.33 → 1.34#135087
k8s-ci-robot merged 3 commits intokubernetes:release-1.34from
liggitt:automated-cherry-pick-of-#135017-upstream-release-1.34

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Nov 4, 2025

Cherry pick of #135017 on release-1.34.

#135017: Fix spurious statefulset rollout from 1.33 → 1.34

For details on the cherry pick process, see the cherry pick requests page.

kube-controller-manager: Fixes a 1.34 regression, which triggered a spurious rollout of existing statefulsets when upgrading the control plane from 1.33 → 1.34. This fix is guarded by a `StatefulSetSemanticRevisionComparison` feature gate, which is enabled by default.

@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 4, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Nov 4, 2025
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Nov 4, 2025
@liggitt liggitt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2025
This was broken since 666a41c when the label value became non-integer encoded
The chance of one controller revision hash label being int-parsable: 7/27 ^ 8 = 0.00002041 = ~0
The chance of both being int-parsable: 0.00002041^2 = ~0

Hash comparison locks in differences in content failing EqualRevision
even when the semantic content is normalized to be equal.
@liggitt liggitt force-pushed the automated-cherry-pick-of-#135017-upstream-release-1.34 branch from 908db7d to aade7b8 Compare November 4, 2025 02:18
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Nov 4, 2025
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 4, 2025

/assign @janetkuo

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 4, 2025

/hold for green CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 4, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
Copy link
Copy Markdown
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 29e9382257dc2eb8e8bf9de8c9ebed782f529570

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 4, 2025

cc @kubernetes/release-managers

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 11a8eb6 into kubernetes:release-1.34 Nov 8, 2025
17 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Nov 8, 2025
@liggitt liggitt deleted the automated-cherry-pick-of-#135017-upstream-release-1.34 branch November 8, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants