Skip to content

Automated cherry pick of #115315: kubelet/client: collapse transport wiring onto standard#115566

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.26from
enj:automated-cherry-pick-of-#115315-upstream-release-1.26
Feb 10, 2023
Merged

Automated cherry pick of #115315: kubelet/client: collapse transport wiring onto standard#115566
k8s-ci-robot merged 1 commit intokubernetes:release-1.26from
enj:automated-cherry-pick-of-#115315-upstream-release-1.26

Conversation

@enj
Copy link
Copy Markdown
Member

@enj enj commented Feb 7, 2023 •
edited
Loading

Cherry pick of #115315 on release-1.26.

#115315: kubelet/client: collapse transport wiring onto standard

For details on the cherry pick process, see the cherry pick requests page.

The Kubernetes API server now correctly detects and closes existing TLS connections when its client certificate file for kubelet authentication has been rotated.

@enj
kubelet/client: collapse transport wiring onto standard approach
c651e4f 
Signed-off-by: Monis Khan <mok@microsoft.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver labels Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/test do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2023
@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented Feb 7, 2023

/kind bug
/triage accepted
/priority important-soon
/retest

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2023
@bart0sh
Copy link
Copy Markdown
Contributor

bart0sh commented Feb 9, 2023

/lgtm
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 9, 2023

LGTM label has been added.

DetailsGit tree hash: 3f29cc15d7ca5c5e0cc4c24ec0cb363a52ff1603

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 10, 2023
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Feb 10, 2023

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@jeremyrickard jeremyrickard added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1802182 into kubernetes:release-1.26 Feb 10, 2023
@enj enj deleted the automated-cherry-pick-of-#115315-upstream-release-1.26 branch June 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@liggitt liggitt

@bart0sh bart0sh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project

Milestone

v1.26

Development

Successfully merging this pull request may close these issues.

6 participants

@enj @bart0sh @k8s-ci-robot @liggitt @SergeyKanzhelev @jeremyrickard