Skip to content

Adds a Kotlin EAP build on a cron#5687

Merged
sksamuel merged 8 commits intomasterfrom
sks/5665
Feb 17, 2026
Merged

Adds a Kotlin EAP build on a cron#5687
sksamuel merged 8 commits intomasterfrom
sks/5665

Conversation

@sksamuel
Copy link
Copy Markdown
Member

Closes #5665

@sksamuel sksamuel requested a review from a team as a code owner February 17, 2026 06:05
sksamuel and others added 6 commits February 17, 2026 00:05
- Use create("libs") with from(files(...)) instead of named("libraries")
  so version() calls after from() properly override TOML-loaded entries
- Override the single "kotlin" version alias instead of nonexistent
  per-library aliases — all libraries/plugins use version.ref = "kotlin"
- Add the same override to buildSrc/settings.gradle.kts since buildSrc
  has its own independent version catalog

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gradle auto-creates the libs catalog from gradle/libs.versions.toml.
Using create() with from() caused a second from() call, which is not
allowed. Use named() to access the existing catalog instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Gradle 9's auto-created libs catalog cannot be modified via the
versionCatalogs API (create causes duplicate from(), named causes
not found). Use sed to patch libs.versions.toml before the build
instead, which reliably handles both buildSrc and root project.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment thread .github/workflows/kotlin-eap.yml Outdated
Comment thread .github/workflows/master-eap.yml
@@ -19,6 +19,10 @@ dependencyResolutionManagement {
versionCatalogs {
create("libs") {
Copy link
Copy Markdown
Member

@alfonsoristorato alfonsoristorato Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I did this in the examples repo I had to do this defaultLibrariesExtensionName.set("defaultLibs") to avoid conflicts and ensure proper override, I am now a bit confused as to how this worked straight away here - unless you have not yet run this job :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I don't think its ran yet until its merged.
I'll add your line and merge.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the difference might be that this is in build src settings and not the normal settings.?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try now

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge it, I am sure it will be fine 😄

@sksamuel sksamuel merged commit 04bbfef into master Feb 17, 2026
12 checks passed
@sksamuel sksamuel deleted the sks/5665 branch February 17, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Kotlin EAP build variant.

2 participants