Overlapping partial matches causes a higher than possible match value.#5682
Merged
AlexCue987 merged 3 commits intomasterfrom Feb 17, 2026
Merged
Overlapping partial matches causes a higher than possible match value.#5682AlexCue987 merged 3 commits intomasterfrom
AlexCue987 merged 3 commits intomasterfrom
Conversation
Fixed by only including the best partial match for any given range in the expected value. fixes #5677
AlexCue987
reviewed
Feb 13, 2026
|
|
||
| // In case of overlapping partial matches, we eliminate the overlapping ones and only include the longest match | ||
| // for any given slice of the expected collection. | ||
| private fun List<PartialCollectionMatch>.filterOverlapping(): List<PartialCollectionMatch> { |
Member
There was a problem hiding this comment.
would it make sense to make this function internal and unit test it explicitly?
AlexCue987
approved these changes
Feb 16, 2026
Member
AlexCue987
left a comment
There was a problem hiding this comment.
we'll add tests in the next PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed by only including the best partial match for any given range in the expected value.
fixes #5677