Skip to content

fix: pass existing environment variables when executing git#527

Merged
korthout merged 1 commit intokorthout:mainfrom
yafanasiev:fix-git-command-env
Dec 15, 2025
Merged

fix: pass existing environment variables when executing git#527
korthout merged 1 commit intokorthout:mainfrom
yafanasiev:fix-git-command-env

Conversation

@yafanasiev
Copy link
Copy Markdown
Contributor

#510 broke GPG signing by not passing the shell environment variables to git binary execution environment, so variables like GNUPGHOME now have no effect. Now, we pass all of process.env before setting out own custom environment variables.

Signed-off-by: yafanasiev <66992401+yafanasiev@users.noreply.github.com>
Copy link
Copy Markdown
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @yafanasiev 🚀

✅ Successfully tested with korthout/backport-action-test#395.

💭 No need to backport this, as #510 is only available for use since v4.

LGTM 👍

@korthout korthout merged commit 3202288 into korthout:main Dec 15, 2025
1 check passed
@korthout
Copy link
Copy Markdown
Owner

@yafanasiev
Copy link
Copy Markdown
Contributor Author

Thank you @korthout for lightning fast reaction! Can confirm that v4.0.1 is working as expected ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants