Fix threadsPerCore check for Zen 2 (AMD)#149
Merged
klauspost merged 1 commit intoklauspost:masterfrom Oct 26, 2024
maksimio:feat/correct-amd-zen2-htt-detection
Merged
Fix threadsPerCore check for Zen 2 (AMD)#149klauspost merged 1 commit intoklauspost:masterfrom maksimio:feat/correct-amd-zen2-htt-detection
klauspost merged 1 commit intoklauspost:masterfrom
maksimio:feat/correct-amd-zen2-htt-detection
Conversation
klauspost
requested changes
Oct 26, 2024
Owner
klauspost
left a comment
There was a problem hiding this comment.
Great find! While unlikely to ever be hit, I'd propose this as a conservative approach.
Something VM's can be a bit finicky and filter CPUID values.
klauspost
approved these changes
Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @klauspost, thanks for the library! I tried running it on my CPU Ryzen 5 4500u (Zen2) and found that the number of threads per core (2) and physical cores (3) were incorrect and the HTT option was also detected incorrectly. In fact this cpu has 1 thread per core and 6 physical (and logical) cores
I wrote a fix using the PPR for AMD Family 17h Models 00h-0Fh Processors (page 82)
You can find CPUID dump of Ryzen 5 4500u here