Remove unicodedata dependency from idna-data tool#220
Merged
Conversation
…odule Replaces the dependency on unicodedata.normalize() and unicodedata.unidata_version with the pre-computed NFKC_Casefold property from DerivedNormalizationProps.txt, ensuring the tool always uses data matching the requested Unicode version rather than whatever version is bundled with the Python runtime.
U+A7F1 (MODIFIER LETTER CAPITAL S) is now correctly classified as DISALLOWED rather than PVALID, as its NFKC_CF mapping makes it unstable. Previously misclassified because the system Python had older Unicode data that didn't include this codepoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unicodedata.normalize("NFKC", ...)andunicodedata.unidata_versionwith pre-computedNFKC_Casefoldmappings fromDerivedNormalizationProps.txt, downloaded from unicode.org alongside the other data files.