feat: Add closed property to NodeCodeBlock#661
Merged
kivikakk merged 2 commits intokivikakk:mainfrom Oct 29, 2025
Martin005:codeblock-closed-and-sourcepos
Merged
feat: Add closed property to NodeCodeBlock#661kivikakk merged 2 commits intokivikakk:mainfrom Martin005:codeblock-closed-and-sourcepos
closed property to NodeCodeBlock#661kivikakk merged 2 commits intokivikakk:mainfrom
Martin005:codeblock-closed-and-sourcepos
Conversation
Contributor
Author
|
@kivikakk wondering if I should have split this into two PRs, one for each commit. If you want, I can do that :) |
Owner
|
One PR is fine, no need for the extra ceremony :) Thank you!! |
Contributor
|
Thank you so so much for this and the other sourcepos work 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tracking of whether fenced code blocks are properly closed with a closing fence. This is then used to fix the
sourceposof unclosed fenced code blocks.Closes #552, fixes #570