Skip to content

Update to Node 20#30

Merged
christopher-dG merged 1 commit intojulia-actions:mainfrom
palday:patch-1
Apr 5, 2024
Merged

Update to Node 20#30
christopher-dG merged 1 commit intojulia-actions:mainfrom
palday:patch-1

Conversation

@palday
Copy link
Copy Markdown
Contributor

@palday palday commented Apr 5, 2024

This seems to be necessary for compatibility with setup-julia v2

This seems to be necessary for compatibility with setup-julia v2
@christopher-dG christopher-dG merged commit 31e2413 into julia-actions:main Apr 5, 2024
@palday palday deleted the patch-1 branch April 5, 2024 15:32
@DilumAluthge
Copy link
Copy Markdown
Member

Just FYI, in the GitHub Actions ecosystem, this kind of change (upgrading from node16 to node20) is considered a breaking change, which is why I believe the new release should be v2.

Some examples of official actions that made a breaking release (bumped the major version number) when they upgraded from node16 to node20:

  1. actions/checkout went from v3 to v4: https://github.com/actions/checkout/releases/tag/v4.0.0
  2. actions/cache went from v3 to v4: https://github.com/actions/cache/releases/tag/v4.0.0

@DilumAluthge
Copy link
Copy Markdown
Member

@palday Are you okay with me doing the following steps?

  1. Point the v1 tag back to v1.1.2
  2. Delete the v1.1.3 tag
  3. Make a new v2.0.0 tag
  4. Make a new v2 tag that points to v2.0.0

@palday
Copy link
Copy Markdown
Contributor Author

palday commented Apr 5, 2024

@DilumAluthge I have no objections

@DilumAluthge
Copy link
Copy Markdown
Member

I'll perform those steps now.

@DilumAluthge
Copy link
Copy Markdown
Member

I have completed the above steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants