Update UPGRADE-6.0.md#823
Merged
DannyvdSluijs merged 4 commits intojsonrainbow:masterfrom May 5, 2025
Merged
Conversation
Add missing breaking change to upgrade guide
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the UPGRADE-6.0.md upgrade guide by adding a missing section that details the breaking change in the signature of the BaseConstraint::addError method.
- Adds documentation for the new method signature
- Provides before/after code snippets to illustrate the changes
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Thanks copilot |
DannyvdSluijs
approved these changes
May 4, 2025
Collaborator
|
@bbrala changes are okay. This PR is only missing an entry to the changelog. I can add one later this week and merge this pr. Thanks for the efforts. |
Contributor
Author
|
Added changelog entry |
DannyvdSluijs
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing breaking change to upgrade guide
Fixes #822