Build: Verify release using dist repo tarball #5719
Merged
timmywil merged 5 commits intojquery:mainfrom Nov 15, 2025
Merged
Conversation
Member
Author
|
Ran reproducible builds workflow to test: https://github.com/jquery/jquery/actions/runs/19000703415/job/54267017128 No changes were needed on the 4.0.0-rc.1 tag itself, only with the script used to verify. |
dd5416e to
0fc8167
Compare
- get the blog URL from the dist repo README and use that to run release:dist
0fc8167 to
c6866c3
Compare
2 tasks
timmywil
commented
Nov 2, 2025
mgol
previously approved these changes
Nov 7, 2025
Member
mgol
left a comment
There was a problem hiding this comment.
I haven't tested it (I assume you have), but code changes look good to me!
Member
Author
|
@mgol I realized there could be a race condition. Because the dist tag is pushed after the main repo tag, it could run the workflow before the dist tag exists. I made it so it falls back to cloning the main branch. This should make it so verify works during a release whether the tag is there or not, but still support verifying previous releases (>= 4.0.0-rc.1). |
1f605db to
aadc9b5
Compare
More changes are coming so I'll dismiss my review for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run release:distfrom the build.Fixes gh-5693
Checklist