fix(rss/atom): sanitize enclosure URLs containing ä
Conversation
|
@chick-p Thanks for the contribution. Could you provide some simple tests for this please? |
|
@chick-p I can't edit the git branch directly, but here are some ideas for minimal tests: The example from the issue could be added as two new test cases - one for RSS and another for Atom: Invalid: <enclosure url="https://example.com/hello&world.png" />Should be sanitized into this: <enclosure url="https://example.com/hello&world.png" />These examples could be wrapped in minimal XML and RSS files to represent full test cases.
|
eaaeb29 to
1aafed9
Compare
|
@jpmonette @Greenheart |
Greenheart
left a comment
There was a problem hiding this comment.
Thanks for adding the tests! This looks good :)
|
Hey, sorry to bring up an already merged PR, just wondering if there is a timeline for this landing on a release? The 5.2.1 version does not seem to include this fix from what i can see. I currently have a patch with the contents of this PR, but it would be nice to have it on a proper release to drop the patch :) |
Fixes #227.