Add an option to parse string versions into FixedFileInfo#64
Merged
josephspurrier merged 1 commit intojosephspurrier:masterfrom Apr 2, 2025
Merged
Add an option to parse string versions into FixedFileInfo#64josephspurrier merged 1 commit intojosephspurrier:masterfrom
josephspurrier merged 1 commit intojosephspurrier:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During our release pipeline we always need to update all version components of the
versioninfo.json, which is a bit tedious as we not only have to update version strings, but also split the strings an a number components to fill theFixedFileInfostructsWe used to use a small utility to parse and insert new version in to the JSON file, but it seems as a common problem for most of
goversioninfousers (at least for those, who want to add a version into the binary)Here we propose a new CLI option which will use "string versions" set in
StringFileInfo(or using--file-versionand--product-versionflags) to fill the corresponding structs in theFixedFileInfo