Skip to content

Bump MSRV to match clap dependency#301

Closed
rukai wants to merge 1 commit into
jonhoo:mainfrom
rukai:bump_msrv_to_match_clap_dep
Closed

Bump MSRV to match clap dependency#301
rukai wants to merge 1 commit into
jonhoo:mainfrom
rukai:bump_msrv_to_match_clap_dep

Conversation

@rukai

@rukai rukai commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Since clap 4.4 bumped its MSRV to 1.70 inferno no longer builds on 1.64 and needs minimum 1.70
This PR:

  • bumps inferno's MSRV to 1.70
  • makes use of a new stdlib API in 1.70 to drop the is-terminal and rustix dependencies.
    • This was also cargo's motivation for bumping MSRV which is how I noticed we could do the same here.

@rukai rukai force-pushed the bump_msrv_to_match_clap_dep branch from c2be034 to 8af0614 Compare August 25, 2023 02:39
@codecov

codecov Bot commented Aug 25, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (5d88bc3) to head (8af0614).
Report is 44 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          19       19           
  Lines        4385     4385           
=======================================
  Hits         3991     3991           
  Misses        394      394

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

jonhoo
jonhoo reviewed Aug 25, 2023
View reviewed changes

@jonhoo jonhoo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! While I appreciate the PR, I don't think I want to bump inferno's MSRV to 1.70 yet — it is too new for the time being. And I don't think dropping the is-terminal dependency is that valuable in reality. The fact that clap 4.4 no longer supports 1.64 doesn't actually preclude anyone from building inferno with 1.64, as long as they come up with the right lockfile (which, while annoying, is at least possible). If we land these changes, then users of inferno have to use a newer Rust, or pin an older version of inferno.

I haven't formally set an MSRV policy for this crate, but in general I'd be looking at 12-18 months probably.

@rukai

rukai commented Aug 25, 2023

Copy link
Copy Markdown
Contributor Author

Understandable, I'll mark this as draft so it's around when it's needed.

@rukai rukai marked this pull request as draft August 25, 2023 21:16
@jonhoo

jonhoo commented Nov 19, 2024

Copy link
Copy Markdown
Owner

Given I'm about to do a breaking release anyway in #335, I'll land this as part of it! May have to do some cherry-picking, but hey, it did end up useful in the end :D

jonhoo added a commit that referenced this pull request Nov 19, 2024
@jonhoo
Remove reliance on is-terminal
fa94bb4 
Cherry-picks #301
@jonhoo jonhoo mentioned this pull request Nov 19, 2024
Merged
jonhoo added a commit that referenced this pull request Nov 19, 2024
@jonhoo
Remove reliance on is-terminal
75464f9 
Cherry-picks #301
@jonhoo

jonhoo commented Nov 19, 2024

Copy link
Copy Markdown
Owner

Merged in #336

@jonhoo jonhoo closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonhoo jonhoo jonhoo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rukai @jonhoo