Skip to content

MNT refactoring backend APIs#1667

Merged
tomMoral merged 37 commits intojoblib:mainfrom
adrinjalali:refactoring
Mar 6, 2025
Merged

MNT refactoring backend APIs#1667
tomMoral merged 37 commits intojoblib:mainfrom
adrinjalali:refactoring

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

@adrinjalali adrinjalali commented Feb 26, 2025

This is to refactor backend APIs to make them a bit more consistent and understandable.

Not finished yet.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.51%. Comparing base (adc3a7c) to head (2bd353b).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
joblib/_parallel_backends.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
+ Coverage   95.45%   95.51%   +0.05%     
==========================================
  Files          46       46              
  Lines        7731     7741      +10     
==========================================
+ Hits         7380     7394      +14     
+ Misses        351      347       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adrinjalali
Copy link
Copy Markdown
Member Author

Once we're happy with those docstrings in the documentation, we should sync them with the code itself.

@adrinjalali
Copy link
Copy Markdown
Member Author

Do we wanna merge this at this point?

Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more typos but after this, good to go for me :)

Thanks a lot @adrinjalali for digging into this

@tomMoral tomMoral merged commit ad13c66 into joblib:main Mar 6, 2025
28 of 29 checks passed
@adrinjalali adrinjalali deleted the refactoring branch March 6, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants