Add public method to upfront check if call in cache and valid#1584
Add public method to upfront check if call in cache and valid#1584tomMoral merged 6 commits intojoblib:mainfrom
Conversation
77ce1f4 to
267730b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
+ Coverage 95.26% 95.27% +0.01%
==========================================
Files 45 45
Lines 7705 7708 +3
==========================================
+ Hits 7340 7344 +4
+ Misses 365 364 -1 ☔ View full report in Codecov by Sentry. |
Anyone has a clue where the increase of +2 misses comes from? |
tomMoral
left a comment
There was a problem hiding this comment.
Hello,
Thanks for the proposal. I think this is the intent of the check_call_in_cache method.
Instead of adding an extra method, I would avoid duplication and modify the existing method to include checking that the cache is valid.
|
Hello Tom, yeah, I agree with your proposal of instead improving / fixing the already present |
|
@tomMoral I just moved the functionality over to the already existing |
|
it seems that the failure is unrelated, could you push a every in the change log? |
Add name for returned value Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
|
@tomMoral I added a section in the change log. Apart from above docs build error that I still seem to be getting, I would be good to go. |
|
Any idea when this might be released? Just came across the issue thinking check_call_in_cache verifies the cache_validation_callback, but it does not (v1.4.2). Thanks. |
|
We plan to do a sprint and a release in late February. |
Following the reasoning and implementation behind #820, this PR adds a public method to check if a given cached function call is in cache and valid (=meets the cache validation callback function).