Merged
Conversation
|
@jmoiron WDYT about merging this? We've been using it in production for a while and it has been a very useful change for us. |
Owner
|
v1.3.5 |
|
Thanks @jmoiron! |
|
Thank you @jmoiron for still carrying about the repository ❤️ |
|
👋 Hi @jmoiron! I recently updated my application to 1.3.5 and noticed my tests were failing due to this change. I guess I'm one of the victims of Hyrum's law. 🥲 Since this is a breaking change, would you consider making the behavior opt-in? Or, at the very least, updating the major version. Folks won't be expecting a change like this on a patch update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #744.