Correcting invocation of ScrollConsoleScreenBufferW - using pointers instead of values.#1038
Merged
gnodet merged 1 commit intojline:masterfrom Jul 17, 2024
Conversation
3 tasks
…instead of values.
9961b81 to
06d5815
Compare
Member
|
Nice catch, thx @lahodaj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in OpenJDK bug:
https://bugs.openjdk.org/browse/JDK-8336375
the invocation of
ScrollConsoleScreenBufferWin the FFM implementation ofKernel32may crash. I believe the reason is that the lookup/"declared" parameters are pointers:jline3/terminal-ffm/src/main/java/org/jline/terminal/impl/ffm/Kernel32.java
Line 406 in 9489e1b
but the provided/actual invocation parameters are values:
jline3/terminal-ffm/src/main/java/org/jline/terminal/impl/ffm/Kernel32.java
Line 239 in 9489e1b
In OpenJDK, I proposed to change the code to use
.seg, which is consistent with other similar invocations inKernel32, and should ensure a pointer is sent to the native function:openjdk/jdk#20182
The patch herein is basically the same as the OpenJDK patch.
(I am not aware of a way to automatically test this.)