Migrate integration test server from Jetty to Netty#2491
Merged
Conversation
Also refactor routes and endpoints to simplify server bring-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using Jetty 9 as a test dependency, which was the last version of Jetty to support Java 8, our minimum target. However that version is no longer maintained other than under commercial terms. So I'm moving jsoup to use Netty instead, which does support Java 8 and is actively maintained including security updates. (This server is only executed during build tests and only on localhost, so is not security critical; but I believe it's good hygiene to keep dependencies up to date.)
Also refactor routes and endpoints to simplify server bring-up.