Reduce isHeaderPngAccessible() timeout#235
Merged
EyalDelarea merged 9 commits intojfrog:masterfrom Dec 26, 2024
Merged
Conversation
hazeltonl
approved these changes
Dec 15, 2024
ccano2011
approved these changes
Dec 16, 2024
ccano2011
left a comment
There was a problem hiding this comment.
This is a much better option, thanks :)
eyalbe4
suggested changes
Dec 26, 2024
…o reduce_timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.To optimize performance, this PR modifies the process for checking internet availability for the header image. Instead of performing the check repeatedly, the availability is now verified only once, with a reduced timeout to minimize delays.