Skip to content

Support uploading code scanning alerts#203

Merged
RobiNino merged 1 commit intojfrog:masterfrom
RobiNino:sarif-upload
Sep 4, 2024
Merged

Support uploading code scanning alerts#203
RobiNino merged 1 commit intojfrog:masterfrom
RobiNino:sarif-upload

Conversation

@RobiNino
Copy link
Copy Markdown
Contributor

@RobiNino RobiNino commented Sep 4, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Depends on jfrog/jfrog-cli#2683

Running jf docker scan and jf scan commands will record sarif files which will be aggregated and uploaded to the code scanning tab in GitHub UI

Copy link
Copy Markdown
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!
Just I think the node modules can be removed from the git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants