Fix Job Summary disabled on self hosted machines#194
Merged
EyalDelarea merged 3 commits intojfrog:masterfrom Sep 2, 2024
Merged
Fix Job Summary disabled on self hosted machines#194EyalDelarea merged 3 commits intojfrog:masterfrom
EyalDelarea merged 3 commits intojfrog:masterfrom
Conversation
…o fix_on_prem_summaries
EyalDelarea
commented
Sep 2, 2024
| import { join } from 'path'; | ||
| import { lt } from 'semver'; | ||
|
|
||
| export enum MarkdownSection { |
Contributor
Author
There was a problem hiding this comment.
Remove un used code as the sections logic was moved to the CLI
eyalbe4
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.The
enableJobSummaries()function previously attempted to retrieve the temporary directory location using theos.RUNNER_TEMPenvironment variable. However, on self-hosted machines, this variable may be unset. This PR introduces a fallback to the system's default temporary directory when RUNNER_TEMP is not set.Tests for this function have also been added.