Skip to content

Command Summary - Separate Module Table View from Artifacts Tree#1257

Merged
EyalDelarea merged 10 commits intojfrog:devfrom
EyalDelarea:tables_for_scaned_modules
Sep 4, 2024
Merged

Command Summary - Separate Module Table View from Artifacts Tree#1257
EyalDelarea merged 10 commits intojfrog:devfrom
EyalDelarea:tables_for_scaned_modules

Conversation

@EyalDelarea
Copy link
Copy Markdown
Contributor

@EyalDelarea EyalDelarea commented Sep 2, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Summary:

This PR separates the logic for generating markdown related to modules.

Details:

The module display is now divided into two subsections:

Modules with scan results (currently, this applies only to Docker images).
Modules without scan results (e.g., an npm module that is packaged into a tar file and then deleted, which we currently cannot scan easily with a JF command).
Introduced refactoring to improve code maintainability for the future.

Made minor adjustments to titles and UI elements for a better user experience.

Before - Npm modules is displayed on a table

image

After - Generic module is displayed without table:

image

@EyalDelarea EyalDelarea changed the title Separate Module Table View from Artifacts Tree Command Summary - Separate Module Table View from Artifacts Tree Sep 2, 2024
@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Sep 2, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants