Skip to content

Move unnecessary dependencies to devDependencies for babel plugins#15010

Merged
SimenB merged 1 commit intojestjs:mainfrom
liuxingbaoyu:move-dependencies
Jul 23, 2024
Merged

Move unnecessary dependencies to devDependencies for babel plugins#15010
SimenB merged 1 commit intojestjs:mainfrom
liuxingbaoyu:move-dependencies

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Contributor

@liuxingbaoyu liuxingbaoyu commented Apr 5, 2024

Summary

I found it at babel/babel#16413 and although I've added the solution in Babel, it looks like removing them in Jest is fine.

Test plan

CI green

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6cd4b70
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/669f7cebb2dc3c00082b1b7f
😎 Deploy Preview https://deploy-preview-15010--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liuxingbaoyu liuxingbaoyu changed the title Move unnecessary dependencies to devDependencies for babel-plugin-jest-hoist Move unnecessary dependencies to devDependencies for babel plugin Apr 5, 2024
@liuxingbaoyu liuxingbaoyu changed the title Move unnecessary dependencies to devDependencies for babel plugin Move unnecessary dependencies to devDependencies for babel plugins Apr 5, 2024
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 23, 2024

I thought these endes up in our public types, but maybe that has changed?

@liuxingbaoyu
Copy link
Copy Markdown
Contributor Author

liuxingbaoyu commented Apr 23, 2024

You're right! I should look for another solution, especially with babel/babel#16416.

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 24, 2024 •
edited
Loading

Yeah

https://www.runpkg.com/?babel-plugin-jest-hoist@29.6.3/build/index.d.ts
https://www.runpkg.com/?babel-jest@29.7.0/build/index.d.ts

Seems we can remove traverse from the hoist plugin, but core needs to be there for both

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 23, 2024

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jul 23, 2024
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jul 23, 2024

@liuxingbaoyu what are the plans for this one? 🙂

@github-actions github-actions bot removed the Stale label Jul 23, 2024
@liuxingbaoyu
Copy link
Copy Markdown
Contributor Author

liuxingbaoyu commented Jul 23, 2024

Sorry I forgot about it!
I finished #15010 (comment) .

SimenB
SimenB approved these changes Jul 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit b8c5200 into jestjs:main Jul 23, 2024
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Aug 8, 2024

https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.6

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liuxingbaoyu @SimenB