fix(@jest/expect-utils): exclude non-enumerable symbol in object matching#14670
Merged
SimenB merged 2 commits intojestjs:mainfrom Nov 2, 2023
Merged
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
7552f04 to
4f39624
Compare
4f39624 to
b72b21d
Compare
SimenB
approved these changes
Nov 2, 2023
Member
SimenB
left a comment
There was a problem hiding this comment.
This is great, thank you! As this just adds tests I think it's quite safe.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aim to solve #14669. Context is detailed in the issue.
I think it makes more sense to ignore non-enumerable fields in the object when doing the match, otherwise it may have some unexpected behavior mobx is involved.
Test plan
Unit tests has been added