Greptile Summary

This PR extends the class-definition stripping fix from #45 to cover amends with HTTP and package:// URIs and extends with HTTP URIs. It adds a second if let Some(uri) = &module.amends pass that resolves the base source for all URI schemes — reading from http_cache for HTTP, from the extracted zip directory for package:// Zip packages, and from disk for local files — and then calls shift_remove on base_obj for each discovered ClassDef entry. The same shift_remove call is added to the extends branches.

Key observations:

• The new logic correctly handles the HTTP and local-file cases, matching the pattern from the pre-existing amends code.
• In the package:// Zip branch of the injection pass, the zip URL is discarded (bound to _) and replaced with an unsafe find_map over all extracted package directories; this could read source from the wrong package when multiple packages contain a file at the same internal path. The zip URL is available from resolve_package_uri and should be used as the direct key into package_dirs.
• The two new tests only cover local-file amends and extends; the HTTP and package:// code paths added by this PR have no test coverage.

Confidence Score: 3/5

• Safe to merge for the common local-file case, but the package:// Zip path has a correctness bug and the new HTTP/package:// branches are untested.
• The local-file fix is correct and tested. The HTTP fix looks correct (cache key matches what fetch_source stores). However, the Zip branch discards the known zip URL and uses find_map across all package directories, which can return content from the wrong package. Additionally, no tests cover the HTTP or package:// amends/extends paths that this PR claims to fix.
• src/eval.rs — specifically the PackageSource::Zip arm in the amends class-injection block (around line 410).

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[eval_module called] --> B{module.amends?}
    B -- yes --> C{URI scheme}
    C -- http/https --> D[fetch_source → eval_module → base_obj]
    C -- package:// --> E{PackageSource}
    E -- Direct --> F[fetch_source → eval_module → base_obj]
    E -- Zip --> G[extract_package_zip → eval_file → base_obj]
    C -- local/file:// --> H[read file → eval_file → base_obj]
    C -- pkl: --> I[skip]

    D & F & G & H --> J{Second pass: inject class defs}
    J -- http/https --> K[http_cache.get uri]
    J -- package:// Direct --> L[http_cache.get resolved_url]
    J -- package:// Zip --> M["find_map over ALL package_dirs ⚠️"]
    J -- local/file:// --> N[fs::read_to_string path]

    K & L & M & N --> O{parse source OK?}
    O -- yes --> P[for each ClassDef: eval + scope.set + base_obj.shift_remove ✅]
    O -- no --> Q[skip class injection]

    B -- no --> R{module.extends?}
    R -- local/file:// --> S[read + parse + eval_module → base_obj\nfor each ClassDef: shift_remove ✅]
    R -- http/https --> T[fetch_source + parse + eval_module → base_obj\nfor each ClassDef: shift_remove ✅]
    R -- package:// --> U[not handled — silently skipped]

_{Reviews (1): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}