Skip to content

fix(docs): typo in Go Backend#9065

Merged
jdx merged 1 commit intojdx:mainfrom
dolmen:patch-1
Apr 12, 2026
Merged

fix(docs): typo in Go Backend#9065
jdx merged 1 commit intojdx:mainfrom
dolmen:patch-1

Conversation

@dolmen
Copy link
Copy Markdown
Contributor

@dolmen dolmen commented Apr 12, 2026

Fix "go install" flag for building a Go program with given build tags: --tags => -tags

Fix "go install" flag for building a Go program with given build tags: --tags => -tags
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 12, 2026

Greptile Summary

Corrects a documentation typo in the Go backend: go install --tagsgo install -tags, aligning the docs with the actual flag passed in src/backend/go.rs (.arg("-tags")). The fix is accurate — Go uses single-dash flags.

Confidence Score: 5/5

Safe to merge — single-line documentation correction with no code changes.

The change is a one-word typo fix in docs that matches the actual runtime behavior in the Rust source. No logic, config, or test files are touched.

No files require special attention.

Important Files Changed

Filename Overview
docs/dev-tools/backends/go.md Single-line doc fix: corrects --tags-tags to match the actual go install flag used in src/backend/go.rs:115.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["mise.toml\n[tools] tags option"] --> B["GoBackend::install_version_"]
    B --> C["cmd.arg('-tags').arg(tags)"]
    C --> D["go install -tags <tags> <module>@<version>"]
    D --> E["Binary installed to GOBIN"]
Loading

Reviews (1): Last reviewed commit: "fix(docs): typo in Go Backend" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in the Go backend documentation, changing the incorrect --tags flag to the correct -tags flag for go install. The review feedback suggests further enhancing the documentation by capitalizing "Go" and clarifying that multiple tags should be comma-separated.

### `tags`

Specify go build tags (passed as `go install --tags`):
Specify go build tags (passed as `go install -tags`):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While fixing the flag typo, consider capitalizing "Go" as it refers to the language name. Additionally, clarifying that multiple tags should be comma-separated would be helpful for users.

Suggested change
Specify go build tags (passed as `go install -tags`):
Specify Go build tags (comma-separated, passed as go install -tags):

@jdx jdx merged commit 261f406 into jdx:main Apr 12, 2026
36 checks passed
KOBeerose pushed a commit to KobeTools/mise that referenced this pull request Apr 13, 2026
Fix "go install" flag for building a Go program with given build tags:
--tags => -tags
mise-en-dev added a commit that referenced this pull request Apr 13, 2026
### 🐛 Bug Fixes

- **(docs)** typo in Go Backend by @dolmen in
[#9065](#9065)
- **(task)** render dependency templates even when no args are passed by
@MatthiasGrandl in [#9062](#9062)
- support npm semver ranges in devEngines by @risu729 in
[#9061](#9061)

### New Contributors

- @dolmen made their first contribution in
[#9065](#9065)
- @MatthiasGrandl made their first contribution in
[#9062](#9062)
@dolmen dolmen deleted the patch-1 branch April 21, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants