Greptile Summary

This PR fixes a bug in the aqua backend where calling complete_windows_ext on a package whose Windows override URL already ends in .exe (e.g. cloud-sql-proxy) would produce a double .exe.exe suffix. The fix extracts the logic into a shared complete_windows_ext_to_asset helper that guards with s.ends_with(".exe") before appending, and also corrects url() to parse the template string before checking the extension (rather than appending .exe to the raw template). Three unit tests covering the no-double-extension and the append-when-missing cases are included.

Confidence Score: 5/5

Safe to merge — targeted, well-tested bug fix with no logic regressions

All findings are P2 or lower; the fix correctly prevents double .exe, the refactoring is semantically equivalent for existing non-.exe templates, and new tests verify both the fixed case and the positive case.

No files require special attention

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[url() / asset_strs() called] --> B[parse_aqua_str — template substitution]
    B --> C[complete_windows_ext_to_asset]
    C --> D{os == 'windows'?}
    D -- No --> E[return as-is]
    D -- Yes --> F{s.ends_with('.exe')?}
    F -- Yes --> G[return as-is — no double .exe]
    F -- No --> H{complete_windows_ext && format == 'raw'?}
    H -- Yes --> I[append .exe]
    H -- No --> E

_{Reviews (4): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}

The fix is correct — upstream aqua has the same guard. In pkg/config/windows_ext.go, the very first thing completeWindowsExtToAsset does is:

if strings.HasSuffix(asset, ".exe") {
    return asset
}

So the registry data is fine — mise was just missing this check that aqua has.

However, upstream's logic is more nuanced than just the .exe guard — it handles empty format with no file extension, and a configurable windows_ext field. I think this should be refactored to match upstream's completeWindowsExtToAsset decision tree rather than adding point fixes. The duplicated condition across url(), and both branches of asset_strs() should be extracted into a single helper method, mirroring how aqua centralizes this in one function.

This comment was generated by Claude Code.

Addressed the review feedback — refactored to extract a complete_windows_ext_to_asset() helper method that mirrors upstream aqua's completeWindowsExtToAsset decision tree.

Changes in the latest commit:

• Consolidated the duplicated .exe logic from url() and both branches of asset_strs() into a single helper
• Fixed url() to apply .exe after template expansion (matching upstream's order)
• Net -13 lines (duplicated conditions removed)

This comment was generated by Claude Code.