test(e2e): improve runner portability and timeout handling#8437
Merged
test(e2e): improve runner portability and timeout handling#8437
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the e2e test harness’ portability across developer environments by reducing reliance on GNU-specific tools and making GitHub rate-limit waiting optional.
Changes:
- Add portable test-file discovery (
fd→rg→find) and auto-resolve a local debugmisebinary ine2e/run_all_tests. - Replace a hard dependency on external
timeoutin an e2e test with a shell-based timeout implementation. - Add a portable
timeouthelper (preferringtimeout/gtimeout, else shell fallback) toe2e/assert.sh.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
e2e/run_all_tests |
Adds portability helpers for locating mise, waiting for GH rate limits optionally, and discovering test files without fd. |
e2e/cli/test_exec_wrapper_recursion |
Replaces external timeout usage with an internal timeout helper for recursion detection. |
e2e/assert.sh |
Introduces a shared portable timeout function and shell fallback implementation for tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5e34178 to
51e0e53
Compare
Contributor
Greptile SummaryEnhanced e2e test portability across different environments by removing dependencies on GNU-specific tools and adding intelligent fallbacks. Key improvements:
Minor issue:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 51e0e53 |
mise-en-dev
added a commit
that referenced
this pull request
Mar 3, 2026
### 🐛 Bug Fixes - **(swift)** fallback to system pkgutil path on macOS by @mackwic in [#8435](#8435) - **(task)** skip depends_post when pre-dependency fails and main task never runs by @jdx in [#8426](#8426) - Fix regex for tar version check by @autarch in [#8430](#8430) ### 🧪 Testing - **(e2e)** improve runner portability and timeout handling by @mackwic in [#8437](#8437) ### 📦 Registry - fix julia version_expr closure syntax by @jdx in [#8420](#8420) ### Chore - **(ci)** tighten docker workflow tag filter to v[0-9]* by @jdx in [#8422](#8422) - remove devcontainer and docker development setup by @jdx in [#8421](#8421)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve e2e runner portability and robustness across local environments (macOS/Linux, shell/tool availability, GitHub rate-limit handling).
Changes
e2e/run_all_tests:fd->rg->find).misebinary automatically.e2e/cli/test_exec_wrapper_recursion:timeoutwith an internal timeout helper.e2e/assert.sh:timeouthelper (timeout/gtimeout/ shell fallback).Why
The e2e suite should run reliably on developer machines and CI without requiring GNU-specific tools.
Scope
Commits