Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances mise's automation capabilities by integrating its powerful task system directly into hooks and watch_files. This allows users to define more complex and reusable actions that are triggered by lifecycle events or file changes, leveraging mise's existing environment and dependency management for a more robust and streamlined workflow.

Highlights

• Task References in Hooks: Introduced the ability for mise hooks (e.g., enter, leave, preinstall) to reference defined tasks using a { task = "name" } syntax in mise.toml.
• Task References in Watch Files: Enabled watch_files configurations to trigger mise tasks when specified file patterns match, using a task = "name" syntax.
• Unified Task Execution: Implemented task execution for both hooks and watch files as subprocesses via mise --cd <root> run <task>, ensuring proper environment setup, dependency resolution, and MISE_NO_HOOKS=1 respect.
• Mixed Hook Arrays: Supported mixed arrays for hooks, allowing configurations to combine both inline scripts and task references within a single hook definition (e.g., enter = ["echo hello", { task = "setup" }]).
• Schema Updates: Updated the mise.json schema to reflect the new configurations for hooks and watch_files, accommodating the task reference syntax.

Greptile Summary

This PR adds task reference support to hooks and watch_files, allowing configuration like enter = { task = "setup" } instead of inline scripts. Tasks execute as subprocesses via mise --cd <root> run <task>, properly setting MISE_NO_HOOKS=1 to prevent recursion.

Key Changes:

• Added TaskRef variant to HookDef enum for deserializing task references
• Added execute_task functions in both hooks.rs and watch_files.rs
• Updated JSON schema to support task references in both hooks and watch_files
• Comprehensive E2E tests for hooks with task references (enter, leave, preinstall, mixed arrays)

Areas for Improvement:

• watch_files.rs silently prefers task when both task and run are set, unlike hooks which warns about conflicts
• Missing E2E test coverage for watch_files with task references (only hooks are tested)
• JSON schema allows invalid states for watch_files (both or neither run/task can be set)

Confidence Score: 4/5

• Safe to merge with minor inconsistencies in error handling and test coverage
• Core implementation is solid with proper recursion prevention and good test coverage for hooks. Minor issues: watch_files lacks warning for conflicting fields and missing E2E tests. Schema validation could be stricter. No blocking issues.
• src/watch_files.rs needs test coverage for task references and consider adding warning when both run and task are set

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant User
    participant mise
    participant Hook System
    participant Task Executor
    participant Task
    
    User->>mise: trigger hook (e.g., enter directory)
    mise->>Hook System: run_one_hook_with_context()
    
    alt Hook has task reference
        Hook System->>Hook System: Check h.task_name.is_some()
        Hook System->>Task Executor: execute_task()
        Note over Task Executor: Set MISE_NO_HOOKS=1<br/>to prevent recursion
        Task Executor->>Task Executor: cmd("mise", ["--cd", root, "run", task_name])
        Task Executor->>Task: Execute task as subprocess
        Task-->>Task Executor: Task output
        Task Executor-->>Hook System: Result
    else Hook has script
        Hook System->>Hook System: execute()
        Note over Hook System: Render template<br/>and run script
        Hook System-->>mise: Result
    end
    
    Hook System-->>mise: Hook completed
    mise-->>User: Continue

_{Last reviewed commit: 7df3342}

bugbot run

Shouldn't this also be extended to (custom) prepare steps?
Allowing task instead of run?

not sure about that yet, I think in general prepare steps should not be using tasks since they shouldn't be that complicated

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

✅ Performance improvement: bin-paths cached is 13%

❔ This enables us to reference tasks by name, but not pass parameters to it, correct?