feat(vsix): added vsix archives to http backend by sosumappu · Pull Request #8306 · jdx/mise

sosumappu · 2026-02-22T18:22:32Z

Mapped .vsix extension to TarFormat::Zip.

vsix archives are zip archives, without this mapping .vsixarchives are treated as raw and therefore not extracted.

tests :

cargo test
Manual testing with actual .vsix` file:

[tools]
'http:java-debug'.version = "latest"
'http:java-debug'.url = "https://open-vsx.org/api/vscjava/vscode-java-pack/0.30.5/file/vscjava.vscode-java-pack-0.30.5.vsix"

gemini-code-assist · 2026-02-22T18:22:39Z

Summary of Changes

Hello @sosumappu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the HTTP backend's ability to handle .vsix files by correctly identifying them as zip archives. This change is crucial for tools that rely on the HTTP backend to extract content from .vsix packages, preventing them from being treated as unextractable raw data.

Highlights

VSIX Archive Handling: Added support for .vsix files by mapping them to the TarFormat::Zip type, ensuring they are correctly processed as zip archives rather than raw files.

Changelog

src/file.rs
- Mapped the ".vsix" file extension to the TarFormat::Zip enum variant.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly adds support for .vsix archives by mapping the extension to the Zip format in TarFormat::from_ext. This allows the HTTP backend to recognize and extract Visual Studio Extension files as ZIP archives. While the change is correct for the primary installation path, the implementation is currently incomplete as several other locations in the codebase that rely on hardcoded extension lists for archive detection and scoring have not been updated. Specifically, is_archive_format in src/cli/generate/tool_stub.rs and the asset scoring penalties in src/backend/asset_matcher.rs should be updated to ensure a consistent experience across all mise features.

gemini-code-assist · 2026-02-22T18:26:00Z

src/file.rs

            "bz2" | "tbz2" => TarFormat::TarBz2,
            "zst" | "tzst" => TarFormat::TarZst,
            "zip" => TarFormat::Zip,
+            "vsix" => TarFormat::Zip,


While adding .vsix to from_ext correctly enables extraction for the HTTP backend, this change appears to be incomplete as other parts of the codebase still use hardcoded extension lists for archive handling:

is_archive_format (line 553 in src/cli/generate/tool_stub.rs): This function needs to include .vsix so that mise generate tool-stub can correctly identify these files as archives and attempt to auto-detect the binary path within them.

AssetPicker::score_build_penalties (line 356 in src/backend/asset_matcher.rs): There is a -100 penalty explicitly for .vsix files. Now that they are supported as valid archives, this penalty should likely be removed or reduced so that .vsix assets can be correctly auto-detected when they are the primary distribution format for a tool.

open_tar (line 898 in src/file.rs): The Auto match arm should be updated to handle vsix (similar to zip) to avoid falling through to the default TarGz case, which would lead to confusing errors if content inspection is attempted on a VSIX file.

I think we need to handle 1 and 3 here

on it, my bad i oversaw that

Copilot

Pull request overview

This PR updates the HTTP backend’s archive format detection so that .vsix files (which are ZIP archives) are extracted instead of being treated as raw/unextractable blobs.

Changes:

Map the vsix extension to TarFormat::Zip in archive format detection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-22T18:26:53Z

src/file.rs

            "bz2" | "tbz2" => TarFormat::TarBz2,
            "zst" | "tzst" => TarFormat::TarZst,
            "zip" => TarFormat::Zip,
+            "vsix" => TarFormat::Zip,


This adds a new extension→format mapping; please add a small unit test to lock in the behavior (e.g., asserting TarFormat::from_ext("vsix") resolves to TarFormat::Zip). This file already has a #[cfg(test)] module, so it should be straightforward to extend and will prevent regressions in future refactors of from_ext.

jdx · 2026-02-22T18:34:04Z

bugbot run

…rmat for tool_stub

sosumappu · 2026-02-22T18:59:00Z

Added the necessary changes to 1 and 3

is_archive_format()- Added .vsix support
open_tar() - Added vsix to the bail conditions so it's not opened with tar

@jdx

### 🚀 Features - **(conda)** replace custom backend with rattler crates by @jdx in [#8325](#8325) - **(task)** enforce per-task timeout configuration by @tvararu in [#8250](#8250) - **(vsix)** added vsix archives to http backend by @sosumappu in [#8306](#8306) - add core dotnet plugin for .NET SDK management by @jdx in [#8326](#8326) ### 🐛 Bug Fixes - **(conda)** preserve conda_packages on locked install and fix temp file race by @jdx in [#8335](#8335) - **(conda)** deduplicate repodata records to fix solver error on Linux by @jdx in [#8337](#8337) - **(env)** include watch_files in fast-path early exit check by @jdx in [#8317](#8317) - **(env)** clear fish completions when setting/unsetting shell aliases by @jdx in [#8324](#8324) - **(lockfile)** prevent lockfile writes when --locked is set by @jdx in [#8308](#8308) - **(lockfile)** prune orphan tool entries on mise lock by @mackwic in [#8265](#8265) - **(lockfile)** error on contradictory locked=true + lockfile=false config by @jdx in [#8329](#8329) - **(regal)** Update package location by @charlieegan3 in [#8315](#8315) - **(release)** strip markdown heading prefix from communique release title by @jdx in [#8303](#8303) - **(schema)** enforce additionalProperties constraint for env by @adamliang0 in [#8328](#8328) ### 📚 Documentation - Remove incorrect oh-my-zsh plugin ordering comment by @bvosk in [#8323](#8323) - require AI disclosure on GitHub comments by @jdx in [#8330](#8330) ### 📦 Registry - add `oxfmt` by @taoufik07 in [#8316](#8316) ### New Contributors - @adamliang0 made their first contribution in [#8328](#8328) - @tvararu made their first contribution in [#8250](#8250) - @bvosk made their first contribution in [#8323](#8323) - @taoufik07 made their first contribution in [#8316](#8316) - @charlieegan3 made their first contribution in [#8315](#8315) - @sosumappu made their first contribution in [#8306](#8306) ## 📦 Aqua Registry Updates #### New Packages (3) - [`Tyrrrz/FFmpegBin`](https://github.com/Tyrrrz/FFmpegBin) - [`elixir-lang/expert`](https://github.com/elixir-lang/expert) - [`erikjuhani/basalt`](https://github.com/erikjuhani/basalt) #### Updated Packages (5) - [`caarlos0/fork-cleaner`](https://github.com/caarlos0/fork-cleaner) - [`firecow/gitlab-ci-local`](https://github.com/firecow/gitlab-ci-local) - [`jackchuka/mdschema`](https://github.com/jackchuka/mdschema) - [`kunobi-ninja/kunobi-releases`](https://github.com/kunobi-ninja/kunobi-releases) - [`peco/peco`](https://github.com/peco/peco)

Mapped `.vsix` extension to `TarFormat::Zip`. `vsix` archives are zip archives, without this mapping `.vsix`archives are treated as `raw` and therefore not extracted. tests : - `cargo test` - `Manual testing with actual `.vsix` file: ```toml [tools] 'http:java-debug'.version = "latest" 'http:java-debug'.url = "https://open-vsx.org/api/vscjava/vscode-java-pack/0.30.5/file/vscjava.vscode-java-pack-0.30.5.vsix" ```

@jdx

### 🚀 Features - **(conda)** replace custom backend with rattler crates by @jdx in [jdx#8325](jdx#8325) - **(task)** enforce per-task timeout configuration by @tvararu in [jdx#8250](jdx#8250) - **(vsix)** added vsix archives to http backend by @sosumappu in [jdx#8306](jdx#8306) - add core dotnet plugin for .NET SDK management by @jdx in [jdx#8326](jdx#8326) ### 🐛 Bug Fixes - **(conda)** preserve conda_packages on locked install and fix temp file race by @jdx in [jdx#8335](jdx#8335) - **(conda)** deduplicate repodata records to fix solver error on Linux by @jdx in [jdx#8337](jdx#8337) - **(env)** include watch_files in fast-path early exit check by @jdx in [jdx#8317](jdx#8317) - **(env)** clear fish completions when setting/unsetting shell aliases by @jdx in [jdx#8324](jdx#8324) - **(lockfile)** prevent lockfile writes when --locked is set by @jdx in [jdx#8308](jdx#8308) - **(lockfile)** prune orphan tool entries on mise lock by @mackwic in [jdx#8265](jdx#8265) - **(lockfile)** error on contradictory locked=true + lockfile=false config by @jdx in [jdx#8329](jdx#8329) - **(regal)** Update package location by @charlieegan3 in [jdx#8315](jdx#8315) - **(release)** strip markdown heading prefix from communique release title by @jdx in [jdx#8303](jdx#8303) - **(schema)** enforce additionalProperties constraint for env by @adamliang0 in [jdx#8328](jdx#8328) ### 📚 Documentation - Remove incorrect oh-my-zsh plugin ordering comment by @bvosk in [jdx#8323](jdx#8323) - require AI disclosure on GitHub comments by @jdx in [jdx#8330](jdx#8330) ### 📦 Registry - add `oxfmt` by @taoufik07 in [jdx#8316](jdx#8316) ### New Contributors - @adamliang0 made their first contribution in [jdx#8328](jdx#8328) - @tvararu made their first contribution in [jdx#8250](jdx#8250) - @bvosk made their first contribution in [jdx#8323](jdx#8323) - @taoufik07 made their first contribution in [jdx#8316](jdx#8316) - @charlieegan3 made their first contribution in [jdx#8315](jdx#8315) - @sosumappu made their first contribution in [jdx#8306](jdx#8306) ## 📦 Aqua Registry Updates #### New Packages (3) - [`Tyrrrz/FFmpegBin`](https://github.com/Tyrrrz/FFmpegBin) - [`elixir-lang/expert`](https://github.com/elixir-lang/expert) - [`erikjuhani/basalt`](https://github.com/erikjuhani/basalt) #### Updated Packages (5) - [`caarlos0/fork-cleaner`](https://github.com/caarlos0/fork-cleaner) - [`firecow/gitlab-ci-local`](https://github.com/firecow/gitlab-ci-local) - [`jackchuka/mdschema`](https://github.com/jackchuka/mdschema) - [`kunobi-ninja/kunobi-releases`](https://github.com/kunobi-ninja/kunobi-releases) - [`peco/peco`](https://github.com/peco/peco)

feat(vsix): added vsix archives to http backend

e85af86

Copilot AI review requested due to automatic review settings February 22, 2026 18:22

Copilot started reviewing on behalf of sosumappu February 22, 2026 18:23 View session

gemini-code-assist bot reviewed Feb 22, 2026

View reviewed changes

Copilot AI reviewed Feb 22, 2026

View reviewed changes

chore: add handling of vsix to open_tar and hard coding is_archive_fo…

4e51a98

…rmat for tool_stub

jdx merged commit 6cba5c6 into jdx:main Feb 22, 2026
31 of 33 checks passed

mise-en-dev mentioned this pull request Feb 22, 2026

chore: release 2026.2.20 #8304

Merged

jdx mentioned this pull request Feb 23, 2026

refactor: unify archive detection #8137

Merged

BrewTestBot mentioned this pull request Feb 25, 2026

mise 2026.2.20 Homebrew/homebrew-core#269302

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(vsix): added vsix archives to http backend#8306

feat(vsix): added vsix archives to http backend#8306
jdx merged 2 commits intojdx:mainfrom
sosumappu:feature/vsix

sosumappu commented Feb 22, 2026

Uh oh!

gemini-code-assist bot commented Feb 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 22, 2026

Uh oh!

jdx Feb 22, 2026

Uh oh!

sosumappu Feb 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

jdx commented Feb 22, 2026

Uh oh!

sosumappu commented Feb 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sosumappu commented Feb 22, 2026

Uh oh!

gemini-code-assist bot commented Feb 22, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

jdx Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

sosumappu Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

jdx commented Feb 22, 2026

Uh oh!

sosumappu commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sosumappu commented Feb 22, 2026 •

edited

Loading