Skip to content

fix: Bump xx to 2.5#8077

Merged
jdx merged 1 commit intojdx:mainfrom
erickt:fix-xx
Feb 10, 2026
Merged

fix: Bump xx to 2.5#8077
jdx merged 1 commit intojdx:mainfrom
erickt:fix-xx

Conversation

@erickt
Copy link
Contributor

@erickt erickt commented Feb 10, 2026

cargo install mise currently fails because:

  • cargo is selecting xx 2.3.0 for some reason I can't figure out.
  • mise uses xx::suggest.
  • xx added the suggest submodule in 2.4.0.

So this patch updates mise to explicitly depend on xx 2.5 to avoid this issue.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 10, 2026

Summary of Changes

Hello @erickt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build failure when installing mise via cargo. By explicitly upgrading the xx crate dependency to version 2.5, it ensures that the necessary suggest submodule, introduced in xx version 2.4.0, is available, thus resolving the installation problem.

Highlights

  • Dependency Update: Updated the xx dependency in Cargo.toml from version 2 to 2.5.
  • Build Fix: Resolved an issue where cargo install mise was failing due to an incompatible xx dependency version, specifically missing the suggest submodule.
Changelog
  • Cargo.toml
    • Updated the xx crate dependency to version 2.5 to ensure compatibility with mise's usage of the suggest submodule.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a build failure during cargo install mise by bumping the xx crate dependency from version 2 to 2.5. This is a necessary and correct fix, as the suggest submodule used by mise was introduced in xx version 2.4.0. The change is minimal and effectively resolves the reported issue.

For future consideration, to improve dependency consistency across the workspace, you might want to update the xx dependency in crates/mise-interactive-config/Cargo.toml and crates/vfox/Cargo.toml to version 2.5 as well. This is not required for this PR but would be a good follow-up.

@erickt
fix: Bump xx to 2.5
603a1ea 
`cargo install mise` currently fails because:

* cargo is selecting `xx 2.3.0` for some reason I can't figure out.
* mise uses `xx::suggest`.
* `xx` added the `suggest` submodule in 2.4.0.

So this patch updates `mise` to explicitly depend on `xx 2.5` to avoid
this issue.
@jdx
Copy link
Owner

jdx commented Feb 10, 2026

You need to use --locked

@erickt
Copy link
Contributor Author

erickt commented Feb 10, 2026

Pushed up a fix for the gemini suggestion.

I dug a little more, and cargo install mise --locked works right now, so I'm guessing a more recent dependency is forcing a downgrade, but it's not obvious what is requiring it.

@erickt
Copy link
Contributor Author

erickt commented Feb 10, 2026

You need to use --locked

jinx! :) I also am finding the same problem with lzma-rust2, which is getting downgraded to 0.15.3, which fails to compile with the selected crc. Would you want the --locked flag added to https://github.com/jdx/mise/blob/main/docs/installing-mise.md?

@jdx
Copy link
Owner

jdx commented Feb 10, 2026

yeah that would be good

@jdx jdx merged commit e261419 into jdx:main Feb 10, 2026
33 checks passed
@mise-en-dev mise-en-dev mentioned this pull request Feb 10, 2026
Merged
mise-en-dev added a commit that referenced this pull request Feb 10, 2026
@mise-en-dev
chore: release 2026.2.9 (#8074)
321980e 
### 🚀 Features

- auto-select no-YJIT Ruby on older glibc systems by @jdx in
[#8069](#8069)

### 🐛 Bug Fixes

- **(shim)** update mise-shim.exe during self-update on Windows by @jdx
in [#8075](#8075)
- Bump xx to 2.5 by @erickt in
[#8077](#8077)

### 📚 Documentation

- **(ruby)** remove experimental language for precompiled binaries by
@jdx in [#8073](#8073)

### New Contributors

- @erickt made their first contribution in
[#8077](#8077)

## 📦 Aqua Registry Updates

#### Updated Packages (1)

- [`carthage-software/mago`](https://github.com/carthage-software/mago)
@BrewTestBot BrewTestBot mentioned this pull request Feb 10, 2026
Merged
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
@erickt @lucasew
fix: Bump xx to 2.5 (jdx#8077)
7d42c1d 
`cargo install mise` currently fails because:

* cargo is selecting `xx 2.3.0` for some reason I can't figure out.
* mise uses `xx::suggest`.
* `xx` added the `suggest` submodule in 2.4.0.

So this patch updates `mise` to explicitly depend on `xx 2.5` to avoid
this issue.
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
@mise-en-dev @lucasew
chore: release 2026.2.9 (jdx#8074)
bf8fb4a 
### 🚀 Features

- auto-select no-YJIT Ruby on older glibc systems by @jdx in
[jdx#8069](jdx#8069)

### 🐛 Bug Fixes

- **(shim)** update mise-shim.exe during self-update on Windows by @jdx
in [jdx#8075](jdx#8075)
- Bump xx to 2.5 by @erickt in
[jdx#8077](jdx#8077)

### 📚 Documentation

- **(ruby)** remove experimental language for precompiled binaries by
@jdx in [jdx#8073](jdx#8073)

### New Contributors

- @erickt made their first contribution in
[jdx#8077](jdx#8077)

## 📦 Aqua Registry Updates

#### Updated Packages (1)

- [`carthage-software/mago`](https://github.com/carthage-software/mago)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erickt @jdx