Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Input component by introducing a new masking behavior. It allows for a more nuanced approach to sensitive data entry, where the input is visible to the user as they type but automatically masked once submitted. This improves both usability and security for specific use cases, such as entering PINs, without altering the existing full-masking password functionality.

Highlights

• New Feature: mask_on_submit option: Introduced a new mask_on_submit boolean field to the Input struct. When enabled, this allows the user to see their input while typing, but masks the value with asterisks after submission. This is distinct from the existing password option, which masks input during typing as well.
• Enhanced Input Security: This feature provides a practical solution for handling sensitive inputs like PINs, ensuring that the value is not visible in terminal scrollback after submission, while still offering a good user experience during entry.

Greptile Summary

This PR adds a mask_on_submit option to Input that keeps typed characters visible while the user is typing but replaces them with asterisks in the post-submit success render — filling the gap between password (masks at all times) and default cleartext.

Key implementation details:

• New mask_on_submit: bool field on Input, defaulting to false
• Builder method .mask_on_submit(...) following existing conventions
• render_success branching: password → 12 asterisks, mask_on_submit → "*".repeat(chars().count()), otherwise plaintext
• render_input is unchanged (only checks self.password), so mask_on_submit input is correctly visible while typing
• Unicode-safe: uses .chars().count() for the asterisk repeat count, not .len() (byte count)
• Precedence documented: when both password and mask_on_submit are set, password takes precedence
• Comprehensive test coverage includes normal input, empty input, and password mode edge cases

Confidence Score: 5/5

• Safe to merge — well-scoped change with correct implementation, no regressions, and comprehensive test coverage.
• The PR is a small, localized change to a single file that correctly implements the mask_on_submit feature. The implementation properly handles all cases: password mode maintains the original fixed 12-asterisk display, mask_on_submit correctly uses actual character count without spurious padding, empty input is handled correctly, flag precedence is documented, and all code paths are covered by unit tests. No security, data integrity, or compatibility concerns identified.
• No files require special attention

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User types input] --> B{password?}
    B -- yes --> C[render_input: mask each char with '*']
    B -- no --> D[render_input: show plaintext]
    C --> E[User submits]
    D --> E
    E --> F[render_success]
    F --> G{password?}
    G -- yes --> H["Display '************' (12 fixed asterisks)"]
    G -- no --> I{mask_on_submit?}
    I -- yes --> J["Display '*' × chars().count()"]
    I -- no --> K[Display plaintext input]

_{Last reviewed commit: 0779446}